gimpity gimp (#1326)

* Update ru_RU.json

keeping russian lang actual

* ok

* Add gradient to lyric-footer

* *Commit en español Ñ (#1304)

* i hate my life (#1307)

* world is now a better place

* meltdown avoided

* meltdown avoided

* stylize new listen now childs

* full scale artwork, finally

* dynamic width for search categories

* hd all album work

* Update afterPack.js

* force hq quality

* oops

* attempt to fix

* misc cleanup

* why what

* what was i thinking

* fix duplicated text in listen now childs

* Paginate/infinite scroll for  albums, playlists (#1234)

* Infinite scroll, pagination to album, playlists

* move pagination below tracks

* Make page size configurable

* remove renderer

* Mitigate songs / album slow app issue.

* add ratings, library change to web remote (#1285)

* Add compact artist header option (#1308)

* Support compact artist header (optional)

* Add required term

* pain e19 still bugged

* improve pagination styling

* el16 fix

* up 1.5.2

* Disable Fullscreen view when artist/album name is clicked. (#1315)

* Disable Fullscreen view when artist/album name is clicked.

idk why this change didn't exist

* Seperate dash from album name

* Replace `$root.showSearch()` with `app.appRoute('search')`

`$root.showSearch()` prevents going back to previous page from sidebar.

* Fix Anim (#1316)

* make tracks tab active (#1318)

* welp that wasn't it.

* Thnks (#1319)

* Thnks

* i need sleep

* Update cider-playlist.ejs

* remove v-ripple

* attempt to fix flatpak

* Update config.yml

Co-authored-by: h0ckerman <35598335+h0ckerman@users.noreply.github.com>
Co-authored-by: vapormusic <vietanhfat@gmail.com>
Co-authored-by: Monochromish <chillygamer7@gmail.com>
Co-authored-by: Gabriel Davila <56521591+mefsaal@users.noreply.github.com>
Co-authored-by: Core <64542347+coredev-uk@users.noreply.github.com>
Co-authored-by: Maikiwi <stella@mai.kiwi>
Co-authored-by: yazninja <yazlesean@gmail.com>
Co-authored-by: booploops <49113086+booploops@users.noreply.github.com>
Co-authored-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com>
Co-authored-by: Pedro Galhardo <pgalhardo@icloud.com>
Co-authored-by: Monochromish <79590499+Monochromish@users.noreply.github.com>

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,8 @@
 blank_issues_enabled: false
 contact_links:
+  - name: Support Disclaimer
+    url: https://docs.cider.sh/support/disclaimer
+    about: Please read this before creating any issue.
   - name: Feature Request
     url: https://github.com/ciderapp/Cider/discussions/new?category=feature-request
     about: Have a feature you would like to have in the app? Make a request.

package.json

@@ -2,7 +2,7 @@
   "name": "cider",
   "applicationId": "Cider",
   "productName": "Cider",
-  "version": "1.5.1",
+  "version": "1.5.2",
   "description": "A new cross-platform Apple Music experience based on Electron and Vue.js written from scratch with performance in mind.",
   "license": "AGPL-3.0",
   "main": "./build/index.js",

src/renderer/audio/audio.js

@@ -50,7 +50,7 @@ const CiderAudio = {
     connectContext: function (mediaElem) {
         if (!CiderAudio.context) {
             CiderAudio.context = new window.AudioContext({ sampleRate: 96000, latencyHint: "playback"}); // Don't ever remove the sample rate arg. Ask Maikiwi.
-            app.lyricOffset = CiderAudio.context.baseLatency + CiderAudio.context.outputLatency
+            app.lyricOffset = CiderAudio.context.baseLatency + (CiderAudio.context.outputLatency ? CiderAudio.context.outputLatency : 0)
         }
         if (!CiderAudio.source) {
             CiderAudio.source = CiderAudio.context.createMediaElementSource(mediaElem);

src/renderer/main/components/sidebar-library-item.js

@@ -2,7 +2,7 @@ import {html} from "../html.js"
 
 export const sidebarLibraryItem = Vue.component("sidebar-library-item", {
     template: html`
-        <button class="app-sidebar-item"  v-ripple
+        <button class="app-sidebar-item"
                 :class="$root.getSidebarItemClass(page)" @click="$root.setWindowHash(page)">
             <svg-icon :url="svgIconData" :name="'sidebar-' + svgIconName" v-if="svgIconData != ''"/>
             <span class="sidebar-item-text">{{ name }}</span>

src/renderer/views/app/chrome-bottom.ejs

@@ -149,27 +149,27 @@
                    v-b-tooltip.hover :title="formatVolumeTooltip()">
         </div>
         <div class="app-chrome-item generic">
-            <button class="playback-button--small cast" v-ripple
+            <button class="playback-button--small cast" 
                     :title="$root.getLz('term.cast')"
                     v-b-tooltip.hover
                     @click="cfg.advanced.AudioContext ? modals.castMenu = true : (cfg.advanced.AudioContext = true, modals.castMenu = true)"></button>
         </div>
         <div class="app-chrome-item generic">
-            <button class="playback-button--small queue" v-ripple :class="{'active': drawer.panel == 'queue'}"
+            <button class="playback-button--small queue"  :class="{'active': drawer.panel == 'queue'}"
                     :title="$root.getLz('term.queue')"
                     v-b-tooltip.hover
                     @click="invokeDrawer('queue')"></button>
         </div>
         <div class="app-chrome-item generic">
             <template v-if="lyrics && lyrics != [] && lyrics.length > 0">
-                <button class="playback-button--small lyrics" v-ripple
+                <button class="playback-button--small lyrics" 
                         :title="$root.getLz('term.lyrics')"
                         v-b-tooltip.hover
                         :class="{'active': drawer.panel == 'lyrics'}"
                         @click="invokeDrawer('lyrics')"></button>
             </template>
             <template v-else>
-                <button class="playback-button--small lyrics" v-ripple
+                <button class="playback-button--small lyrics" 
                         :style="{'opacity': 0.3, 'pointer-events': 'none'}"></button>
             </template>
 

src/renderer/views/app/chrome-top.ejs

@@ -16,19 +16,19 @@
     <template v-if="getThemeDirective('appNavigation') != 'seperate'">
       <div class="vdiv" v-if="getThemeDirective('windowLayout') == 'twopanel'"></div>
       <div class="app-chrome-item">
-        <button class="playback-button navigation" v-ripple @click="navigateBack()" :title="$root.getLz('term.navigateBack')"
+        <button class="playback-button navigation"  @click="navigateBack()" :title="$root.getLz('term.navigateBack')"
           v-b-tooltip.hover>
           <svg-icon url="./views/svg/chevron-left.svg"></svg-icon>
         </button>
       </div>
       <div class="app-chrome-item">
-        <button class="playback-button navigation" v-ripple @click="navigateForward()"
+        <button class="playback-button navigation"  @click="navigateForward()"
           :title="$root.getLz('term.navigateForward')" v-b-tooltip.hover>
           <svg-icon url="./views/svg/chevron-right.svg"></svg-icon>
         </button>
       </div>
       <div class="app-chrome-item" v-if="getThemeDirective('windowLayout') == 'twopanel'">
-        <button class="playback-button collapseLibrary" v-ripple v-b-tooltip.hover
+        <button class="playback-button collapseLibrary"  v-b-tooltip.hover
           :title="chrome.sidebarCollapsed ? getLz('action.showLibrary') : getLz('action.hideLibrary')"
           @click="chrome.sidebarCollapsed = !chrome.sidebarCollapsed">
           <transition name="fade">
@@ -230,21 +230,21 @@
           :title="formatVolumeTooltip()" />
       </div>
       <div class="app-chrome-item generic">
-        <button class="playback-button--small cast" :title="$root.getLz('term.cast')" v-ripple
+        <button class="playback-button--small cast" :title="$root.getLz('term.cast')" 
           @click="cfg.advanced.AudioContext ? modals.castMenu = true : (cfg.advanced.AudioContext = true, modals.castMenu = true)"
           v-b-tooltip.hover></button>
       </div>
       <div class="app-chrome-item generic">
-        <button class="playback-button--small queue" :title="$root.getLz('term.queue')" v-b-tooltip.hover v-ripple
+        <button class="playback-button--small queue" :title="$root.getLz('term.queue')" v-b-tooltip.hover 
           :class="{'active': drawer.panel == 'queue'}" @click="invokeDrawer('queue')"></button>
       </div>
       <div class="app-chrome-item generic">
         <template v-if="lyrics && lyrics != [] && lyrics.length > 0">
-          <button class="playback-button--small lyrics" :title="$root.getLz('term.lyrics')" v-b-tooltip.hover v-ripple
+          <button class="playback-button--small lyrics" :title="$root.getLz('term.lyrics')" v-b-tooltip.hover 
             :class="{'active': drawer.panel == 'lyrics'}" @click="invokeDrawer('lyrics')"></button>
         </template>
         <template v-else>
-          <button class="playback-button--small lyrics" :style="{'opacity': 0.3, 'pointer-events': 'none'}" v-ripple></button>
+          <button class="playback-button--small lyrics" :style="{'opacity': 0.3, 'pointer-events': 'none'}" ></button>
         </template>
       </div>
     </template>

src/renderer/views/components/sidebar-playlist.ejs

@@ -1,6 +1,6 @@
 <script type="text/x-template" id="sidebar-playlist">
     <div class="sidebar-playlist" :key="item.id">
-        <button class="app-sidebar-item app-sidebar-item-playlist" :key="item.id" v-ripple
+        <button class="app-sidebar-item app-sidebar-item-playlist" :key="item.id" 
                 :class="item.type != 'library-playlist-folders' ? {'active': $root.page.includes(item.id)} : ['playlist-folder', {'folder-button-active': folderOpened}, isPlaylistSelected]"
                 @contextmenu="playlistContextMenu($event, item.id)"
                 @dragstart="startDrag($event, item)"