From cd332573bc14cf499bccd7314899cac410f6cfbb Mon Sep 17 00:00:00 2001 From: cryptofyre Date: Wed, 27 Jul 2022 10:59:32 -0500 Subject: [PATCH] gimpity gimp (#1326) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update ru_RU.json keeping russian lang actual * ok * Add gradient to lyric-footer * *Commit en español Ñ (#1304) * i hate my life (#1307) * world is now a better place * meltdown avoided * meltdown avoided * stylize new listen now childs * full scale artwork, finally * dynamic width for search categories * hd all album work * Update afterPack.js * force hq quality * oops * attempt to fix * misc cleanup * why what * what was i thinking * fix duplicated text in listen now childs * Paginate/infinite scroll for albums, playlists (#1234) * Infinite scroll, pagination to album, playlists * move pagination below tracks * Make page size configurable * remove renderer * Mitigate songs / album slow app issue. * add ratings, library change to web remote (#1285) * Add compact artist header option (#1308) * Support compact artist header (optional) * Add required term * pain e19 still bugged * improve pagination styling * el16 fix * up 1.5.2 * Disable Fullscreen view when artist/album name is clicked. (#1315) * Disable Fullscreen view when artist/album name is clicked. idk why this change didn't exist * Seperate dash from album name * Replace `$root.showSearch()` with `app.appRoute('search')` `$root.showSearch()` prevents going back to previous page from sidebar. * Fix Anim (#1316) * make tracks tab active (#1318) * welp that wasn't it. * Thnks (#1319) * Thnks * i need sleep * Update cider-playlist.ejs * remove v-ripple * attempt to fix flatpak * Update config.yml Co-authored-by: h0ckerman <35598335+h0ckerman@users.noreply.github.com> Co-authored-by: vapormusic Co-authored-by: Monochromish Co-authored-by: Gabriel Davila <56521591+mefsaal@users.noreply.github.com> Co-authored-by: Core <64542347+coredev-uk@users.noreply.github.com> Co-authored-by: Maikiwi Co-authored-by: yazninja Co-authored-by: booploops <49113086+booploops@users.noreply.github.com> Co-authored-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com> Co-authored-by: Pedro Galhardo Co-authored-by: Monochromish <79590499+Monochromish@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/config.yml | 3 +++ package.json | 2 +- src/renderer/audio/audio.js | 2 +- .../main/components/sidebar-library-item.js | 2 +- src/renderer/views/app/chrome-bottom.ejs | 8 ++++---- src/renderer/views/app/chrome-top.ejs | 14 +++++++------- src/renderer/views/components/sidebar-playlist.ejs | 2 +- 7 files changed, 18 insertions(+), 15 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index d25be6c5..00c9fea1 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,5 +1,8 @@ blank_issues_enabled: false contact_links: + - name: Support Disclaimer + url: https://docs.cider.sh/support/disclaimer + about: Please read this before creating any issue. - name: Feature Request url: https://github.com/ciderapp/Cider/discussions/new?category=feature-request about: Have a feature you would like to have in the app? Make a request. diff --git a/package.json b/package.json index 9aa21352..7b37c78a 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "cider", "applicationId": "Cider", "productName": "Cider", - "version": "1.5.1", + "version": "1.5.2", "description": "A new cross-platform Apple Music experience based on Electron and Vue.js written from scratch with performance in mind.", "license": "AGPL-3.0", "main": "./build/index.js", diff --git a/src/renderer/audio/audio.js b/src/renderer/audio/audio.js index de6b8d82..99f1a3f4 100644 --- a/src/renderer/audio/audio.js +++ b/src/renderer/audio/audio.js @@ -50,7 +50,7 @@ const CiderAudio = { connectContext: function (mediaElem) { if (!CiderAudio.context) { CiderAudio.context = new window.AudioContext({ sampleRate: 96000, latencyHint: "playback"}); // Don't ever remove the sample rate arg. Ask Maikiwi. - app.lyricOffset = CiderAudio.context.baseLatency + CiderAudio.context.outputLatency + app.lyricOffset = CiderAudio.context.baseLatency + (CiderAudio.context.outputLatency ? CiderAudio.context.outputLatency : 0) } if (!CiderAudio.source) { CiderAudio.source = CiderAudio.context.createMediaElementSource(mediaElem); diff --git a/src/renderer/main/components/sidebar-library-item.js b/src/renderer/main/components/sidebar-library-item.js index 19c157f4..adf31689 100644 --- a/src/renderer/main/components/sidebar-library-item.js +++ b/src/renderer/main/components/sidebar-library-item.js @@ -2,7 +2,7 @@ import {html} from "../html.js" export const sidebarLibraryItem = Vue.component("sidebar-library-item", { template: html` -
-
diff --git a/src/renderer/views/app/chrome-top.ejs b/src/renderer/views/app/chrome-top.ejs index 1ea16cad..fed618d8 100644 --- a/src/renderer/views/app/chrome-top.ejs +++ b/src/renderer/views/app/chrome-top.ejs @@ -16,19 +16,19 @@ diff --git a/src/renderer/views/components/sidebar-playlist.ejs b/src/renderer/views/components/sidebar-playlist.ejs index f27cb56b..494b812e 100644 --- a/src/renderer/views/components/sidebar-playlist.ejs +++ b/src/renderer/views/components/sidebar-playlist.ejs @@ -1,6 +1,6 @@