From 04b001b2c2522e7b024ce5c74253ec9e501dc860 Mon Sep 17 00:00:00 2001 From: Amaru8 <52407090+Amaru8@users.noreply.github.com> Date: Sun, 10 Apr 2022 16:33:57 +0000 Subject: [PATCH 1/4] Added translatability to "Open artwork in browser" --- src/i18n/README.md | 4 ++++ src/i18n/en_US.json | 1 + src/i18n/source/en_US.json | 1 + src/renderer/views/components/mediaitem-artwork.ejs | 2 +- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/i18n/README.md b/src/i18n/README.md index d6f26900..a345760f 100644 --- a/src/i18n/README.md +++ b/src/i18n/README.md @@ -234,3 +234,7 @@ Update 09/04/2022 11:00 UTC * `term.disablePrivateSession`: Added for `en_US` +Update 10/04/2022 22:30 UTC + +* `action.openArtworkInBrowser`: Added for `en_US` + diff --git a/src/i18n/en_US.json b/src/i18n/en_US.json index 1b71dabe..89c8e219 100644 --- a/src/i18n/en_US.json +++ b/src/i18n/en_US.json @@ -258,6 +258,7 @@ "action.cast.scan": "Scan", "action.cast.scanning": "Scanning...", "action.createNew": "Create New...", + "action.openArtworkInBrowser": "Open artwork in browser", "settings.header.general": "General", "settings.header.general.description": "Adjust the general settings for Cider.", "settings.option.general.language": "Language", diff --git a/src/i18n/source/en_US.json b/src/i18n/source/en_US.json index 1b71dabe..89c8e219 100644 --- a/src/i18n/source/en_US.json +++ b/src/i18n/source/en_US.json @@ -258,6 +258,7 @@ "action.cast.scan": "Scan", "action.cast.scanning": "Scanning...", "action.createNew": "Create New...", + "action.openArtworkInBrowser": "Open artwork in browser", "settings.header.general": "General", "settings.header.general.description": "Adjust the general settings for Cider.", "settings.option.general.language": "Language", diff --git a/src/renderer/views/components/mediaitem-artwork.ejs b/src/renderer/views/components/mediaitem-artwork.ejs index 16a79210..3358aefd 100644 --- a/src/renderer/views/components/mediaitem-artwork.ejs +++ b/src/renderer/views/components/mediaitem-artwork.ejs @@ -66,7 +66,7 @@ app.showMenuPanel({ items: { "save": { - name: "Open artwork in browser", + name: "{{$root.getLz('action.openArtworkInBrowser')}}", action: () => { window.open(app.getMediaItemArtwork(self.url, 1024, 1024)) } From daca5f4249c2e38de918f3554f34acb141e0fbee Mon Sep 17 00:00:00 2001 From: Amaru8 Date: Sun, 10 Apr 2022 18:43:22 +0200 Subject: [PATCH 2/4] maybe fix --- src/renderer/views/components/mediaitem-artwork.ejs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/views/components/mediaitem-artwork.ejs b/src/renderer/views/components/mediaitem-artwork.ejs index 3358aefd..b75eda96 100644 --- a/src/renderer/views/components/mediaitem-artwork.ejs +++ b/src/renderer/views/components/mediaitem-artwork.ejs @@ -66,7 +66,7 @@ app.showMenuPanel({ items: { "save": { - name: "{{$root.getLz('action.openArtworkInBrowser')}}", + name: "$root.getLz('action.openArtworkInBrowser')", action: () => { window.open(app.getMediaItemArtwork(self.url, 1024, 1024)) } From a047da449b6c3b89d1064d227f4e6ad23b14e9a7 Mon Sep 17 00:00:00 2001 From: Amaru8 <52407090+Amaru8@users.noreply.github.com> Date: Mon, 11 Apr 2022 13:33:38 +0000 Subject: [PATCH 3/4] finally --- src/i18n/README.md | 2 +- src/renderer/views/components/mediaitem-artwork.ejs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/i18n/README.md b/src/i18n/README.md index a345760f..ae84a0e9 100644 --- a/src/i18n/README.md +++ b/src/i18n/README.md @@ -234,7 +234,7 @@ Update 09/04/2022 11:00 UTC * `term.disablePrivateSession`: Added for `en_US` -Update 10/04/2022 22:30 UTC +Update 11/04/2022 13:45 UTC * `action.openArtworkInBrowser`: Added for `en_US` diff --git a/src/renderer/views/components/mediaitem-artwork.ejs b/src/renderer/views/components/mediaitem-artwork.ejs index b75eda96..40ebe15b 100644 --- a/src/renderer/views/components/mediaitem-artwork.ejs +++ b/src/renderer/views/components/mediaitem-artwork.ejs @@ -66,7 +66,7 @@ app.showMenuPanel({ items: { "save": { - name: "$root.getLz('action.openArtworkInBrowser')", + name: app.getLz('action.openArtworkInBrowser'), action: () => { window.open(app.getMediaItemArtwork(self.url, 1024, 1024)) } From c700f88a9696c7dd24b3a718367d741d13dda23e Mon Sep 17 00:00:00 2001 From: Amaru8 Date: Mon, 11 Apr 2022 15:40:31 +0200 Subject: [PATCH 4/4] Translated to Hungarian --- src/i18n/hu_HU.json | 1 + 1 file changed, 1 insertion(+) diff --git a/src/i18n/hu_HU.json b/src/i18n/hu_HU.json index 01b19e71..7570157d 100644 --- a/src/i18n/hu_HU.json +++ b/src/i18n/hu_HU.json @@ -258,6 +258,7 @@ "action.cast.scan": "Keresés", "action.cast.scanning": "Keresés folyamatban...", "action.createNew": "Új létrehozása...", + "action.openArtworkInBrowser": "Borító megnyitása a böngészőben", "settings.header.general": "Általános", "settings.header.general.description": "A Cider általános beállításainak módosítása.", "settings.option.general.language": "Nyelv",