From 8edfddc409dd03aa2c7fd6a475de0a5ed15aa0ff Mon Sep 17 00:00:00 2001
From: Tobias Speicher <rootcommander@gmail.com>
Date: Sun, 20 Feb 2022 15:09:12 +0100
Subject: [PATCH] Replace deprecated String.prototype.substr()

String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() or substring() which work similarily but aren't deprecated.
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
---
 src/main/base/browserwindow.ts                       | 2 +-
 src/renderer/index.js                                | 2 +-
 src/renderer/views/components/mediaitem-square.ejs   | 2 +-
 src/web-remote/views/components/mediaitem-square.ejs | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/base/browserwindow.ts b/src/main/base/browserwindow.ts
index d6fc722d..b015b24a 100644
--- a/src/main/base/browserwindow.ts
+++ b/src/main/base/browserwindow.ts
@@ -695,7 +695,7 @@ export class BrowserWindow {
 
             let latestbranchjson = await latestbranch.json()
             let base_url = latestbranchjson[0].url
-            base_url = base_url.substr(0, base_url.lastIndexOf('/'))
+            base_url = base_url.substring(0, base_url.lastIndexOf('/'))
 
             const options: any = {
                 provider: 'generic',
diff --git a/src/renderer/index.js b/src/renderer/index.js
index 38a61ede..d318ec4f 100644
--- a/src/renderer/index.js
+++ b/src/renderer/index.js
@@ -2497,7 +2497,7 @@ const app = new Vue({
             let richsync = [];
             const lang = app.cfg.lyrics.mxm_language //  translation language
             function revisedRandId() {
-                return Math.random().toString(36).replace(/[^a-z]+/g, '').substr(2, 10);
+                return Math.random().toString(36).replace(/[^a-z]+/g, '').slice(2, 10);
             }
 
             /* get token */
diff --git a/src/renderer/views/components/mediaitem-square.ejs b/src/renderer/views/components/mediaitem-square.ejs
index 6be015b1..ed3b5ad7 100644
--- a/src/renderer/views/components/mediaitem-square.ejs
+++ b/src/renderer/views/components/mediaitem-square.ejs
@@ -145,7 +145,7 @@
                 }
             },
             revisedRandId() {
-                return Math.random().toString(36).replace(/[^a-z]+/g, '').substr(2, 10);
+                return Math.random().toString(36).replace(/[^a-z]+/g, '').slice(2, 10);
             },
             async isInLibrary() {
                 if (this.item.type && !this.item.type.includes("library")) {
diff --git a/src/web-remote/views/components/mediaitem-square.ejs b/src/web-remote/views/components/mediaitem-square.ejs
index 67fae157..90e9aa9b 100644
--- a/src/web-remote/views/components/mediaitem-square.ejs
+++ b/src/web-remote/views/components/mediaitem-square.ejs
@@ -153,7 +153,7 @@
                 }
             },
             revisedRandId() {
-                return Math.random().toString(36).replace(/[^a-z]+/g, '').substr(2, 10);
+                return Math.random().toString(36).replace(/[^a-z]+/g, '').slice(2, 10);
             },
             async isInLibrary() {
                 if (this.item.type && !this.item.type.includes("library")) {