From 268886b1ecd173a1e09018af6a45cdd4a3a5efd8 Mon Sep 17 00:00:00 2001 From: child_duckling <19170969+child-duckling@users.noreply.github.com> Date: Thu, 16 Dec 2021 21:01:06 -0800 Subject: [PATCH 1/4] revert, using rest instead --- .github/workflows/build-analyze-linux.yml | 11 +---------- .github/workflows/build-analyze-macos.yml | 6 ------ .github/workflows/build-analyze-win.yml | 5 ----- 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/.github/workflows/build-analyze-linux.yml b/.github/workflows/build-analyze-linux.yml index 3b087a24..96bf2437 100644 --- a/.github/workflows/build-analyze-linux.yml +++ b/.github/workflows/build-analyze-linux.yml @@ -73,13 +73,4 @@ jobs: yarn install yarn dist -p never - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v1 - - - name: Upload a Build Artifact - uses: actions/upload-artifact@v2.2.3 - with: - # Artifact name - name: Artifacts - # A file, directory or wildcard pattern that describes what to upload - path: dist/ - # The desired behavior if no files are found using the provided path. + uses: github/codeql-action/analyze@v1 \ No newline at end of file diff --git a/.github/workflows/build-analyze-macos.yml b/.github/workflows/build-analyze-macos.yml index 168ce99c..09742410 100644 --- a/.github/workflows/build-analyze-macos.yml +++ b/.github/workflows/build-analyze-macos.yml @@ -80,9 +80,3 @@ jobs: # A file, directory or wildcard pattern that describes what to upload path: dist/ # The desired behavior if no files are found using the provided path. - - - - name: GitHub Upload Release Artifacts - # You may pin to the exact commit or the version. - # uses: Roang-zero1/github-upload-release-artifacts-action@f0677c0645db8d52dddaee4e83ce2c150f95e8e1 - uses: Roang-zero1/github-upload-release-artifacts-action@v2.1.0 diff --git a/.github/workflows/build-analyze-win.yml b/.github/workflows/build-analyze-win.yml index d57486b3..17d8f248 100644 --- a/.github/workflows/build-analyze-win.yml +++ b/.github/workflows/build-analyze-win.yml @@ -80,8 +80,3 @@ jobs: # A file, directory or wildcard pattern that describes what to upload path: dist/ # The desired behavior if no files are found using the provided path. - - - name: GitHub Upload Release Artifacts - # You may pin to the exact commit or the version. - # uses: Roang-zero1/github-upload-release-artifacts-action@f0677c0645db8d52dddaee4e83ce2c150f95e8e1 - uses: Roang-zero1/github-upload-release-artifacts-action@v2.1.0 From 28579979b13a352919932750dcd96943e205b367 Mon Sep 17 00:00:00 2001 From: vapormusic Date: Fri, 17 Dec 2021 12:02:30 +0700 Subject: [PATCH 2/4] test build windows --- .github/workflows/build-analyze-win.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build-analyze-win.yml b/.github/workflows/build-analyze-win.yml index 17d8f248..de7513a6 100644 --- a/.github/workflows/build-analyze-win.yml +++ b/.github/workflows/build-analyze-win.yml @@ -80,3 +80,8 @@ jobs: # A file, directory or wildcard pattern that describes what to upload path: dist/ # The desired behavior if no files are found using the provided path. + - name: Release + uses: softprops/action-gh-release@v1 + if: startsWith(github.ref, 'refs/tags/') + with: + files: dist/Cider Setup 1.0.0.exe \ No newline at end of file From e19bbc4115b1965e94975f0f624d61119d16d33b Mon Sep 17 00:00:00 2001 From: vapormusic Date: Fri, 17 Dec 2021 12:04:52 +0700 Subject: [PATCH 3/4] do we need this --- .github/workflows/build-analyze-win.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-analyze-win.yml b/.github/workflows/build-analyze-win.yml index de7513a6..1e28d221 100644 --- a/.github/workflows/build-analyze-win.yml +++ b/.github/workflows/build-analyze-win.yml @@ -84,4 +84,5 @@ jobs: uses: softprops/action-gh-release@v1 if: startsWith(github.ref, 'refs/tags/') with: - files: dist/Cider Setup 1.0.0.exe \ No newline at end of file + files: dist/Cider Setup 1.0.0.exe + \ No newline at end of file From a0b93c1d5db7286410c408ebd7fdfcdab827682e Mon Sep 17 00:00:00 2001 From: vapormusic Date: Fri, 17 Dec 2021 12:06:04 +0700 Subject: [PATCH 4/4] fix workflow --- .github/workflows/build-analyze-win.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-analyze-win.yml b/.github/workflows/build-analyze-win.yml index 1e28d221..5d46cd95 100644 --- a/.github/workflows/build-analyze-win.yml +++ b/.github/workflows/build-analyze-win.yml @@ -81,8 +81,8 @@ jobs: path: dist/ # The desired behavior if no files are found using the provided path. - name: Release - uses: softprops/action-gh-release@v1 - if: startsWith(github.ref, 'refs/tags/') - with: - files: dist/Cider Setup 1.0.0.exe - \ No newline at end of file + uses: softprops/action-gh-release@v1 + if: startsWith(github.ref, 'refs/tags/') + with: + files: dist/Cider Setup 1.0.0.exe +