From 6bb589bfbe596cac916579e45b83d0f123ae3b7b Mon Sep 17 00:00:00 2001
From: Mefsaal <mefsaal@gmail.com>
Date: Mon, 25 Apr 2022 00:35:19 -0300
Subject: [PATCH] No hardcoded strings for options menu and added to en_US for
 now and  support other languages

---
 src/i18n/README.md                    | 14 ++++++++++++++
 src/i18n/en_US.json                   | 11 +++++++++++
 src/i18n/source/en_US.json            | 11 +++++++++++
 src/renderer/views/pages/settings.ejs | 22 +++++++++++-----------
 4 files changed, 47 insertions(+), 11 deletions(-)

diff --git a/src/i18n/README.md b/src/i18n/README.md
index eba2e4b7..bfa14070 100644
--- a/src/i18n/README.md
+++ b/src/i18n/README.md
@@ -267,3 +267,17 @@ Update 22/04/2022 13:00 UTC
 * `settings.option.general.keybindings`: Added for `en_US`
 * `settings.option.general.keybindings.open`: Added for `en_US`
 
+Update 25/04/2022 00:21 UTC
+
+*  `settings.description.search`: Added for `en_US`
+*  `settings.description.albums`: Added for `en_US`
+*  `settings.description.artists`: Added for `en_US`
+*  `settings.description.browse`: Added for `en_US`
+*  `settings.description.private`: Added for `en_US`
+*  `settings.description.remote`: Added for `en_US`
+*  `settings.description.audio`: Added for `en_US`
+*  `settings.description.plugins`: Added for `en_US`
+*  `settings.description.cast`: Added for `en_US`
+*  `settings.description.settings`: Added for `en_US`
+*  `settings.description.developer`: Added for `en_US`
+
diff --git a/src/i18n/en_US.json b/src/i18n/en_US.json
index 198cada2..c6204a12 100644
--- a/src/i18n/en_US.json
+++ b/src/i18n/en_US.json
@@ -281,6 +281,17 @@
   "settings.option.general.customizeSidebar.customize": "Customize",
   "settings.option.general.keybindings": "Keybindings",
   "settings.option.general.keybindings.open": "Open",
+  "settings.description.search": "Search",
+  "settings.description.albums": "Library Albums",
+  "settings.description.artists": "Library Artists",
+  "settings.description.browse": "Browse",
+  "settings.description.private": "Toogle Private Session",
+  "settings.description.remote": "Web Remote",
+  "settings.description.audio": "Audio Settings",
+  "settings.description.plugins": "Plugins Menu",
+  "settings.description.cast": "Cast to Devices",
+  "settings.description.settings": "Settings",
+  "settings.description.developer": "Developer Tools",
   "settings.notyf.updateCider.update-not-available": "No update available",
   "settings.notyf.updateCider.update-downloaded": "Update has been downloaded, restart to apply",
   "settings.notyf.updateCider.update-error": "Error updating Cider",
diff --git a/src/i18n/source/en_US.json b/src/i18n/source/en_US.json
index e22e8e6f..d11bd4fc 100644
--- a/src/i18n/source/en_US.json
+++ b/src/i18n/source/en_US.json
@@ -281,6 +281,17 @@
   "settings.option.general.customizeSidebar.customize": "Customize",
   "settings.option.general.keybindings": "Keybindings",
   "settings.option.general.keybindings.open": "Open",
+  "settings.description.search": "Search",
+  "settings.description.albums": "Library Albums",
+  "settings.description.artists": "Library Artists",
+  "settings.description.browse": "Browse",
+  "settings.description.private": "Toogle Private Session",
+  "settings.description.remote": "Web Remote",
+  "settings.description.audio": "Audio Settings",
+  "settings.description.plugins": "Plugins Menu",
+  "settings.description.cast": "Cast to Devices",
+  "settings.description.settings": "Settings",
+  "settings.description.developer": "Developer Tools",
   "settings.notyf.updateCider.update-not-available": "No update available",
   "settings.notyf.updateCider.update-downloaded": "Update has been downloaded, restart to apply",
   "settings.notyf.updateCider.update-error": "Error updating Cider",
diff --git a/src/renderer/views/pages/settings.ejs b/src/renderer/views/pages/settings.ejs
index c49551d8..0b2bee89 100644
--- a/src/renderer/views/pages/settings.ejs
+++ b/src/renderer/views/pages/settings.ejs
@@ -136,7 +136,7 @@
                                 <div class="settings-option-body">
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Search
+                                            {{$root.getLz('settings.description.search')}}
                                         </div>        
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + F</p>
@@ -144,7 +144,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Library Albums
+                                            {{$root.getLz('settings.description.albums')}}
                                         </div>        
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + A</p>
@@ -152,7 +152,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Library Artist
+                                            {{$root.getLz('settings.description.artists')}}
                                         </div>        
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + D</p>
@@ -160,7 +160,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Browse
+                                            {{$root.getLz('settings.description.browse')}}
                                         </div>        
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + B</p>
@@ -168,7 +168,7 @@
                                     </div>                               
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Toggle Private Session
+                                            {{$root.getLz('settings.description.private')}}
                                         </div>
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + P</p>
@@ -176,7 +176,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Web Remote
+                                            {{$root.getLz('settings.description.remote')}}
                                         </div>
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + Shift + W</p>
@@ -184,7 +184,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Audio Settings
+                                            {{$root.getLz('settings.description.audio')}}
                                         </div>
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + Shift + A</p>
@@ -192,7 +192,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Plugin Menu
+                                            {{$root.getLz('settings.description.plugins')}}
                                         </div>
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + Shift + P</p>
@@ -200,7 +200,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Cast to Devices
+                                            {{$root.getLz('settings.description.cast')}}
                                         </div>
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + Shift + C</p>
@@ -208,7 +208,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Toggle Settings
+                                            {{$root.getLz('settings.description.settings')}}
                                         </div>        
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + S</p>
@@ -216,7 +216,7 @@
                                     </div>
                                     <div class="md-option-line">
                                         <div class="md-option-segment">
-                                            Open Developer Tools
+                                            {{$root.getLz('settings.description.developer')}}
                                         </div>
                                         <div class="md-option-segment md-option-segment_auto keybindings-border">
                                             <p class="keybinding-text">{{ getCommandOrControl() }} + {{ getOptionOrShift() }} + I</p>