From f3be9177812cd5677b3f6ffb42337e8acba0b037 Mon Sep 17 00:00:00 2001 From: Mefsaal Date: Fri, 22 Apr 2022 00:50:45 -0300 Subject: [PATCH 1/4] Added new complementary keybinds --- src/renderer/main/events.js | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/renderer/main/events.js b/src/renderer/main/events.js index 672963f7..1a5ec29f 100644 --- a/src/renderer/main/events.js +++ b/src/renderer/main/events.js @@ -18,7 +18,9 @@ const Events = { }); document.addEventListener('keydown', async function (event) { + // CTRL + F if (event.keyCode === 70 && event.ctrlKey) { + app.appRoute('search') app.$refs.searchInput.focus() app.$refs.searchInput.select() } @@ -35,7 +37,19 @@ const Events = { if (event.keyCode === 82 && event.ctrlKey && event.shiftKey) { event.preventDefault() window.location.reload() - } + } + // CTRL + S + if (event.keyCode === 83 && event.ctrlKey) { + app.appRoute("settings") + } + // CTRL + A + if (event.keyCode === 65 && event.ctrlKey) { + app.appRoute("library-albums") + } + // CTRL + B + if (event.keyCode === 66 && event.ctrlKey) { + app.appRoute("browse") + } // CTRL + E if (event.keyCode === 69 && event.ctrlKey) { app.invokeDrawer('queue') From 94490c542a98c874a99b7ab521eac65705539b83 Mon Sep 17 00:00:00 2001 From: Mefsaal Date: Fri, 22 Apr 2022 01:05:13 -0300 Subject: [PATCH 2/4] another one (Test maybe change later) --- src/renderer/main/events.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/renderer/main/events.js b/src/renderer/main/events.js index 1a5ec29f..63631db6 100644 --- a/src/renderer/main/events.js +++ b/src/renderer/main/events.js @@ -49,6 +49,10 @@ const Events = { // CTRL + B if (event.keyCode === 66 && event.ctrlKey) { app.appRoute("browse") + } + // CTRL + D + if (event.keyCode === 68 && event.ctrlKey) { + app.appRoute("library-artists") } // CTRL + E if (event.keyCode === 69 && event.ctrlKey) { From 75a7f24ad8b4aa1e4dc1642872d4ab5ccb192a08 Mon Sep 17 00:00:00 2001 From: Mefsaal Date: Sun, 24 Apr 2022 19:21:38 -0300 Subject: [PATCH 3/4] Toogle Setting in Popup --- src/renderer/views/pages/settings.ejs | 40 +++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/src/renderer/views/pages/settings.ejs b/src/renderer/views/pages/settings.ejs index 71cba409..c49551d8 100644 --- a/src/renderer/views/pages/settings.ejs +++ b/src/renderer/views/pages/settings.ejs @@ -134,6 +134,38 @@
+
+
+ Search +
+
+

{{ getCommandOrControl() }} + F

+
+
+
+
+ Library Albums +
+
+

{{ getCommandOrControl() }} + A

+
+
+
+
+ Library Artist +
+
+

{{ getCommandOrControl() }} + D

+
+
+
+
+ Browse +
+
+

{{ getCommandOrControl() }} + B

+
+
Toggle Private Session @@ -174,6 +206,14 @@

{{ getCommandOrControl() }} + Shift + C

+
+
+ Toggle Settings +
+
+

{{ getCommandOrControl() }} + S

+
+
Open Developer Tools From 6bb589bfbe596cac916579e45b83d0f123ae3b7b Mon Sep 17 00:00:00 2001 From: Mefsaal Date: Mon, 25 Apr 2022 00:35:19 -0300 Subject: [PATCH 4/4] No hardcoded strings for options menu and added to en_US for now and support other languages --- src/i18n/README.md | 14 ++++++++++++++ src/i18n/en_US.json | 11 +++++++++++ src/i18n/source/en_US.json | 11 +++++++++++ src/renderer/views/pages/settings.ejs | 22 +++++++++++----------- 4 files changed, 47 insertions(+), 11 deletions(-) diff --git a/src/i18n/README.md b/src/i18n/README.md index eba2e4b7..bfa14070 100644 --- a/src/i18n/README.md +++ b/src/i18n/README.md @@ -267,3 +267,17 @@ Update 22/04/2022 13:00 UTC * `settings.option.general.keybindings`: Added for `en_US` * `settings.option.general.keybindings.open`: Added for `en_US` +Update 25/04/2022 00:21 UTC + +* `settings.description.search`: Added for `en_US` +* `settings.description.albums`: Added for `en_US` +* `settings.description.artists`: Added for `en_US` +* `settings.description.browse`: Added for `en_US` +* `settings.description.private`: Added for `en_US` +* `settings.description.remote`: Added for `en_US` +* `settings.description.audio`: Added for `en_US` +* `settings.description.plugins`: Added for `en_US` +* `settings.description.cast`: Added for `en_US` +* `settings.description.settings`: Added for `en_US` +* `settings.description.developer`: Added for `en_US` + diff --git a/src/i18n/en_US.json b/src/i18n/en_US.json index 198cada2..c6204a12 100644 --- a/src/i18n/en_US.json +++ b/src/i18n/en_US.json @@ -281,6 +281,17 @@ "settings.option.general.customizeSidebar.customize": "Customize", "settings.option.general.keybindings": "Keybindings", "settings.option.general.keybindings.open": "Open", + "settings.description.search": "Search", + "settings.description.albums": "Library Albums", + "settings.description.artists": "Library Artists", + "settings.description.browse": "Browse", + "settings.description.private": "Toogle Private Session", + "settings.description.remote": "Web Remote", + "settings.description.audio": "Audio Settings", + "settings.description.plugins": "Plugins Menu", + "settings.description.cast": "Cast to Devices", + "settings.description.settings": "Settings", + "settings.description.developer": "Developer Tools", "settings.notyf.updateCider.update-not-available": "No update available", "settings.notyf.updateCider.update-downloaded": "Update has been downloaded, restart to apply", "settings.notyf.updateCider.update-error": "Error updating Cider", diff --git a/src/i18n/source/en_US.json b/src/i18n/source/en_US.json index e22e8e6f..d11bd4fc 100644 --- a/src/i18n/source/en_US.json +++ b/src/i18n/source/en_US.json @@ -281,6 +281,17 @@ "settings.option.general.customizeSidebar.customize": "Customize", "settings.option.general.keybindings": "Keybindings", "settings.option.general.keybindings.open": "Open", + "settings.description.search": "Search", + "settings.description.albums": "Library Albums", + "settings.description.artists": "Library Artists", + "settings.description.browse": "Browse", + "settings.description.private": "Toogle Private Session", + "settings.description.remote": "Web Remote", + "settings.description.audio": "Audio Settings", + "settings.description.plugins": "Plugins Menu", + "settings.description.cast": "Cast to Devices", + "settings.description.settings": "Settings", + "settings.description.developer": "Developer Tools", "settings.notyf.updateCider.update-not-available": "No update available", "settings.notyf.updateCider.update-downloaded": "Update has been downloaded, restart to apply", "settings.notyf.updateCider.update-error": "Error updating Cider", diff --git a/src/renderer/views/pages/settings.ejs b/src/renderer/views/pages/settings.ejs index c49551d8..0b2bee89 100644 --- a/src/renderer/views/pages/settings.ejs +++ b/src/renderer/views/pages/settings.ejs @@ -136,7 +136,7 @@
- Search + {{$root.getLz('settings.description.search')}}

{{ getCommandOrControl() }} + F

@@ -144,7 +144,7 @@
- Library Albums + {{$root.getLz('settings.description.albums')}}

{{ getCommandOrControl() }} + A

@@ -152,7 +152,7 @@
- Library Artist + {{$root.getLz('settings.description.artists')}}

{{ getCommandOrControl() }} + D

@@ -160,7 +160,7 @@
- Browse + {{$root.getLz('settings.description.browse')}}

{{ getCommandOrControl() }} + B

@@ -168,7 +168,7 @@
- Toggle Private Session + {{$root.getLz('settings.description.private')}}

{{ getCommandOrControl() }} + P

@@ -176,7 +176,7 @@
- Web Remote + {{$root.getLz('settings.description.remote')}}

{{ getCommandOrControl() }} + Shift + W

@@ -184,7 +184,7 @@
- Audio Settings + {{$root.getLz('settings.description.audio')}}

{{ getCommandOrControl() }} + Shift + A

@@ -192,7 +192,7 @@
- Plugin Menu + {{$root.getLz('settings.description.plugins')}}

{{ getCommandOrControl() }} + Shift + P

@@ -200,7 +200,7 @@
- Cast to Devices + {{$root.getLz('settings.description.cast')}}

{{ getCommandOrControl() }} + Shift + C

@@ -208,7 +208,7 @@
- Toggle Settings + {{$root.getLz('settings.description.settings')}}

{{ getCommandOrControl() }} + S

@@ -216,7 +216,7 @@
- Open Developer Tools + {{$root.getLz('settings.description.developer')}}

{{ getCommandOrControl() }} + {{ getOptionOrShift() }} + I