From 1f2b0a9a362bbc892992f294a64a152e03190ba2 Mon Sep 17 00:00:00 2001 From: Jason Chen Date: Mon, 17 Jan 2022 13:50:16 -0800 Subject: [PATCH 1/6] Add genre in artist bio --- src/renderer/views/pages/artist.ejs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/renderer/views/pages/artist.ejs b/src/renderer/views/pages/artist.ejs index b2f6d490..bc1e10c3 100644 --- a/src/renderer/views/pages/artist.ejs +++ b/src/renderer/views/pages/artist.ejs @@ -115,6 +115,10 @@

{{ data.attributes.isGroup ? "Formed" : "Born" }}

{{ data.attributes.bornOrFormed }} +
+

Genre

+ {{ data.attributes.genreNames.join(', ') }} +
From 01d3cbbaa583de0401436c5c5006ad0c97c241c9 Mon Sep 17 00:00:00 2001 From: Jason Chen Date: Mon, 17 Jan 2022 13:54:51 -0800 Subject: [PATCH 2/6] Include no results when a search query returns undefined --- src/renderer/views/pages/search.ejs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/renderer/views/pages/search.ejs b/src/renderer/views/pages/search.ejs index f056ecdb..da315005 100644 --- a/src/renderer/views/pages/search.ejs +++ b/src/renderer/views/pages/search.ejs @@ -7,6 +7,10 @@ +
+

No Results

+

Try a new search.

+
@@ -91,10 +95,10 @@ }, methods: { getTopResult() { - if (this.search.results["meta"]) { + try { return this.search.results[this.search.results.meta.results.order[0]]["data"][0] - } else { - return false; + } catch( error ) { + return false } } } From f1a247218e07523b186a3bc4d5e31658a40ace9b Mon Sep 17 00:00:00 2001 From: Jason Chen Date: Mon, 17 Jan 2022 14:38:56 -0800 Subject: [PATCH 3/6] adjusted margin for expanded description to center --- src/renderer/views/pages/artist.ejs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/views/pages/artist.ejs b/src/renderer/views/pages/artist.ejs index bc1e10c3..ee9f2d72 100644 --- a/src/renderer/views/pages/artist.ejs +++ b/src/renderer/views/pages/artist.ejs @@ -31,7 +31,7 @@
-
+
From dee5f3b74c2567fe49852de6b13dd3d061324687 Mon Sep 17 00:00:00 2001 From: Jason Chen Date: Tue, 18 Jan 2022 11:24:00 -0800 Subject: [PATCH 5/6] centered song title when explicit-icon is shown --- src/renderer/views/main.ejs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/renderer/views/main.ejs b/src/renderer/views/main.ejs index 65687523..9201b1e4 100644 --- a/src/renderer/views/main.ejs +++ b/src/renderer/views/main.ejs @@ -82,7 +82,8 @@
-
+
{{ mk.nowPlayingItem["attributes"]["name"] }}
From cc191fb5e73740d8e58d47756de75c19db674c3c Mon Sep 17 00:00:00 2001 From: Jason Chen Date: Tue, 18 Jan 2022 11:47:45 -0800 Subject: [PATCH 6/6] remove em dash when playingItem is not in an album --- src/renderer/views/main.ejs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/views/main.ejs b/src/renderer/views/main.ejs index 9201b1e4..c5f5466b 100644 --- a/src/renderer/views/main.ejs +++ b/src/renderer/views/main.ejs @@ -94,7 +94,7 @@ {{ mk.nowPlayingItem["attributes"]["artistName"] }}
+ @click="getNowPlayingItemDetailed('album')" v-if="mk.nowPlayingItem['attributes']['albumName'] != ''">
{{"—"}}
{{(mk.nowPlayingItem["attributes"]["albumName"]) ? (mk.nowPlayingItem["attributes"]["albumName"]) : "" }}