From 5417484722e6b9775d6b27b5bf9b1fac21cae4d5 Mon Sep 17 00:00:00 2001 From: Amaru8 <52407090+Amaru8@users.noreply.github.com> Date: Mon, 9 May 2022 22:26:39 +0200 Subject: [PATCH 1/5] Add hide_timestamp to store --- src/main/base/store.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/base/store.ts b/src/main/base/store.ts index f059a1fe..9f809a08 100644 --- a/src/main/base/store.ts +++ b/src/main/base/store.ts @@ -17,6 +17,7 @@ export class Store { "client": "Cider", "clear_on_pause": true, "hide_buttons": false, + "hide_timestamp": false, "state_format": "by {artist}", "details_format": "{title}", }, From 8ee81c75747aaa7bdbdcf6d15eb2cd3e601714d4 Mon Sep 17 00:00:00 2001 From: Amaru8 <52407090+Amaru8@users.noreply.github.com> Date: Mon, 9 May 2022 22:27:48 +0200 Subject: [PATCH 2/5] Add hideTimestamp to en_US and source --- src/i18n/en_US.json | 1 + src/i18n/source/en_US.json | 1 + 2 files changed, 2 insertions(+) diff --git a/src/i18n/en_US.json b/src/i18n/en_US.json index 2b1e581b..10aa9e00 100644 --- a/src/i18n/en_US.json +++ b/src/i18n/en_US.json @@ -472,6 +472,7 @@ "settings.option.connectivity.discordRPC.clientName": "Client Name", "settings.option.connectivity.discordRPC.clearOnPause": "Clear Discord Rich Presence on Pause", "settings.option.connectivity.discordRPC.hideButtons": "Hide buttons on Discord Rich Presence", + "settings.option.connectivity.discordRPC.hideTimestamp": "Hide timestamp on Discord Rich Presence", "settings.option.connectivity.discordRPC.detailsFormat": "Details Format", "settings.option.connectivity.discordRPC.stateFormat": "State Format", "settings.option.connectivity.lastfmScrobble": "Last.fm Scrobbling", diff --git a/src/i18n/source/en_US.json b/src/i18n/source/en_US.json index 2b1e581b..10aa9e00 100644 --- a/src/i18n/source/en_US.json +++ b/src/i18n/source/en_US.json @@ -472,6 +472,7 @@ "settings.option.connectivity.discordRPC.clientName": "Client Name", "settings.option.connectivity.discordRPC.clearOnPause": "Clear Discord Rich Presence on Pause", "settings.option.connectivity.discordRPC.hideButtons": "Hide buttons on Discord Rich Presence", + "settings.option.connectivity.discordRPC.hideTimestamp": "Hide timestamp on Discord Rich Presence", "settings.option.connectivity.discordRPC.detailsFormat": "Details Format", "settings.option.connectivity.discordRPC.stateFormat": "State Format", "settings.option.connectivity.lastfmScrobble": "Last.fm Scrobbling", From 4cfcf88fdbd0390768f6d5c20a4defe45fb81897 Mon Sep 17 00:00:00 2001 From: Amaru8 <52407090+Amaru8@users.noreply.github.com> Date: Mon, 9 May 2022 22:28:33 +0200 Subject: [PATCH 3/5] Add hideTimestamp to hu_HU --- src/i18n/hu_HU.json | 1 + 1 file changed, 1 insertion(+) diff --git a/src/i18n/hu_HU.json b/src/i18n/hu_HU.json index 8108143d..ca93b58e 100644 --- a/src/i18n/hu_HU.json +++ b/src/i18n/hu_HU.json @@ -416,6 +416,7 @@ "settings.option.connectivity.discordRPC.clientName": "Kliensnév", "settings.option.connectivity.discordRPC.clearOnPause": "Rich Presence törlése megállításnál", "settings.option.connectivity.discordRPC.hideButtons": "Rich Presence gombok elrejtése", + "settings.option.connectivity.discordRPC.hideTimestamp": "Rich Presence visszaszámláló elrejtése", "settings.option.connectivity.discordRPC.detailsFormat": "Részletek formátuma", "settings.option.connectivity.discordRPC.stateFormat": "Állapot formátuma", "settings.option.connectivity.lastfmScrobble": "Last.fm Scrobbling", From 541e46683bba7e53355a55607fcceedb2c716a43 Mon Sep 17 00:00:00 2001 From: Amaru8 <52407090+Amaru8@users.noreply.github.com> Date: Mon, 9 May 2022 22:29:13 +0200 Subject: [PATCH 4/5] Add check to discordrpc.ts --- src/main/plugins/discordrpc.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/plugins/discordrpc.ts b/src/main/plugins/discordrpc.ts index c943eb68..fe933903 100644 --- a/src/main/plugins/discordrpc.ts +++ b/src/main/plugins/discordrpc.ts @@ -183,8 +183,8 @@ export default class DiscordRPC { ] //To change attributes.url => preload/cider-preload.js } - // Add the timestamp if its playing - if (attributes.status) { + // Add the timestamp if its playing and people want them + if (!this._utils.getStoreValue("general.discordrpc.hide_timestamp") && attributes.status) { activity.startTimestamp = Date.now() - (attributes?.durationInMillis - attributes?.remainingTime) activity.endTimestamp = attributes.endTime } From 7f4f80adea7970f1a921969744bc501a8c83c238 Mon Sep 17 00:00:00 2001 From: Amaru8 <52407090+Amaru8@users.noreply.github.com> Date: Mon, 9 May 2022 22:30:07 +0200 Subject: [PATCH 5/5] Add hideTimestamp to settings --- src/renderer/views/pages/settings.ejs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/renderer/views/pages/settings.ejs b/src/renderer/views/pages/settings.ejs index 875f08bf..59088eab 100644 --- a/src/renderer/views/pages/settings.ejs +++ b/src/renderer/views/pages/settings.ejs @@ -1067,6 +1067,17 @@ +
+
+ {{$root.getLz('settings.option.connectivity.discordRPC.hideTimestamp')}} +
+
+ +
+
+
{{$root.getLz('settings.option.connectivity.discordRPC.detailsFormat')}}