okseby/orchard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Changes close button behavior to close button should hide - LOCALE CHANE NOTED IN README

Browse source
This commit is contained in:
Core 2022-01-30 16:15:35 +00:00
parent c393436c25
commit 0ab0bd7b77
No known key found for this signature in database
GPG key ID: FE9BF1B547F8F3C6
4 changed files with 16 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/i18n/README.md
View file

@ -1,8 +1,18 @@
# Cider i18n
Some notes about Cider's i18n support.
* Localization files are stored in jsonc format aka "JSON with Comments"
* The default language is English.
* The default language is used for messages that are not translated.
* Try when possible to keep the messages the similar in length to the English ones.
* Most of the strings in the content area are provided and translated by Apple themselves, and do not need to be translated.
* The language Apple Music uses are dependent on the storefront region.
* Most of the strings in the content area are provided and translated by Apple themselves, and do not need to be
translated.
* The language Apple Music uses are dependent on the storefront region.
## Localization Notices
Several changes have been made to configuration options and will be listed below with the relevant locales that have
been modified, the ones not mentioned in the list need modifying.
* `settings.option.experimental.closeButtonBehaviour`: Changed to `close_button_hide` - Should be "Close Button Should Hide the Application". `.quit`, `.minimizeTaskbar` and `.minimizeTray` have been removed. Translations done for en_US.

5
src/i18n/en_US.jsonc
View file

@ -263,10 +263,7 @@
"settings.header.experimental": "Experimental",
"settings.header.experimental.description": "Adjust the experimental settings for Cider.",
"settings.option.experimental.compactUI": "Compact UI", // Toggle
"settings.option.experimental.closeButtonBehaviour": "Close Button Behavior",
"settings.option.experimental.closeButtonBehaviour.quit": "Quit Cider",
"settings.option.experimental.closeButtonBehaviour.minimizeTaskbar": "Minimize to Taskbar",
"settings.option.experimental.closeButtonBehaviour.minimizeTray": "Minimize to Tray",
"settings.option.experimental.close_button_hide": "Close Button Should Hide the Application",
// Refer to term.disabled & term.enabled
// Spatialization Menu

2
src/main/base/store.ts
View file

@ -6,7 +6,7 @@ export class ConfigStore {
private defaults: any = {
"general": {
"close_behavior": 0, // 0 = close, 1 = minimize, 2 = minimize to tray
"close_button_hide": true,
"open_on_startup": false,
"discord_rpc": 1, // 0 = disabled, 1 = enabled as Cider, 2 = enabled as Apple Music
"discord_rpc_clear_on_pause": true,

14
src/renderer/views/pages/settings.ejs
View file

@ -598,20 +598,10 @@
</div>
<div class="md-option-line">
<div class="md-option-segment">
{{$root.getLz("settings.option.experimental.closeButtonBehaviour")}}
{{$root.getLz("settings.option.experimental.close_button_hide")}}
</div>
<div class="md-option-segment md-option-segment_auto">
<select class="md-select" v-model="app.cfg.general.close_behavior" @change="sendDataToMTT()">
<option value="0">
{{$root.getLz("settings.option.experimental.closeButtonBehaviour.quit")}}
</option>
<option value="1">
{{$root.getLz("settings.option.experimental.closeButtonBehaviour.minimizeTaskbar")}}
</option>
<option value="2">
{{$root.getLz("settings.option.experimental.closeButtonBehaviour.minimizeTray")}}
</option>
</select>
<input type="checkbox" v-model="app.cfg.general.close_button_hide" switch/>
</div>
</div>
</div>