Update to audio quality setting clarity (Translators note i18n README.md)

- Changed audio quality setting to match MusicKit audio options (Low -> Standard)
- Added descriptions for audio quality options
- Audio quality now uses string for setting instead of direct bitrate option.
This commit is contained in:
Core 2022-02-06 10:58:30 +00:00
parent c86d66d142
commit 0131a1a70a
No known key found for this signature in database
GPG key ID: FE9BF1B547F8F3C6
5 changed files with 27 additions and 29 deletions

View file

@ -56,3 +56,12 @@ Update 05/02/2022 09:00 UTC
* `settings.header.audio.quality.lossless.description`: Added for `en_US`. * `settings.header.audio.quality.lossless.description`: Added for `en_US`.
* `settings.option.audio.enableAdvancedFunctionality.ciderPPE`: Added for `en_US`. * `settings.option.audio.enableAdvancedFunctionality.ciderPPE`: Added for `en_US`.
* `settings.option.audio.enableAdvancedFunctionality.ciderPPE.description`: Added for `en_US`. * `settings.option.audio.enableAdvancedFunctionality.ciderPPE.description`: Added for `en_US`.
Update 06/02/2022 10:35 UTC
* `settings.header.audio.quality.hireslossless.description`: Brackets removed, handled in renderer.
* `settings.header.audio.quality.lossless.description`: Brackets removed, handled in renderer.
* `settings.header.audio.quality.high.description`: Added for `en_US`.
* `settings.header.audio.quality.auto`: Removed as default for MusicKit is 256.
* `settings.header.audio.quality.standard`: Replaced `settings.header.audio.quality.low` to match MusicKit naming.
* `settings.header.audio.quality.standard.description`: Added for `en_US`.

View file

@ -222,13 +222,13 @@
"settings.header.audio.description": "Adjust the audio settings for Cider.", "settings.header.audio.description": "Adjust the audio settings for Cider.",
"settings.option.audio.quality": "Audio Quality", // Dropdown "settings.option.audio.quality": "Audio Quality", // Dropdown
"settings.header.audio.quality.hireslossless": "Hi-Res Lossless", "settings.header.audio.quality.hireslossless": "Hi-Res Lossless",
"settings.header.audio.quality.hireslossless.description": "(up to 24-bit/192 kHz)", "settings.header.audio.quality.hireslossless.description": "up to 24-bit/192 kHz",
"settings.header.audio.quality.lossless": "Lossless", "settings.header.audio.quality.lossless": "Lossless",
"settings.header.audio.quality.lossless.description": "(up to 24-bit/48 kHz)", "settings.header.audio.quality.lossless.description": "up to 24-bit/48 kHz",
"settings.header.audio.quality.enhanced": "Enhanced",
"settings.header.audio.quality.high": "High", "settings.header.audio.quality.high": "High",
"settings.header.audio.quality.low": "Low", "settings.header.audio.quality.high.description": "256 kbps",
"settings.header.audio.quality.auto": "Auto", "settings.header.audio.quality.standard": "Standard",
"settings.header.audio.quality.standard.description": "64 kbps",
"settings.option.audio.seamlessTransition": "Seamless Audio Transition", // Toggle "settings.option.audio.seamlessTransition": "Seamless Audio Transition", // Toggle
"settings.option.audio.enableAdvancedFunctionality": "Enable Advanced Functionality", // Toggle "settings.option.audio.enableAdvancedFunctionality": "Enable Advanced Functionality", // Toggle
"settings.option.audio.enableAdvancedFunctionality.description": "Enabling AudioContext functionality will allow for extended audio features like Audio Normalization , Equalizers and Visualizers, however on some systems this may cause stuttering in audio tracks.", "settings.option.audio.enableAdvancedFunctionality.description": "Enabling AudioContext functionality will allow for extended audio features like Audio Normalization , Equalizers and Visualizers, however on some systems this may cause stuttering in audio tracks.",

View file

@ -28,7 +28,7 @@ export class Store {
"volume": 1, "volume": 1,
"lastVolume": 1, "lastVolume": 1,
"muted": false, "muted": false,
"quality": "256", "quality": "HIGH",
"seamless_audio": true, "seamless_audio": true,
"normalization": false, "normalization": false,
"ciderPPE": false, "ciderPPE": false,

View file

@ -670,23 +670,13 @@ const app = new Vue({
window.localStorage.setItem("currentQueue", JSON.stringify(app.mk.queue.items)) window.localStorage.setItem("currentQueue", JSON.stringify(app.mk.queue.items))
}; };
// Load saved quality if (typeof MusicKit.PlaybackBitrate[app.cfg.audio.quality] !== "string") {
switch (app.cfg.audio.quality) { app.mk.bitrate = MusicKit.PlaybackBitrate[app.cfg.audio.quality]
case "extreme": } else {
app.mk.bitrate = app.cfg.audio.quality = 990 app.mk.bitrate = 256
break; app.cfg.audio.quality = "HIGH"
case "high":
app.mk.bitrate = app.cfg.audio.quality = 256
break;
case "low":
app.mk.bitrate = app.cfg.audio.quality = 64
break;
default:
// app.mk.bitrate = app.cfg.audio.quality
break;
} }
// load last played track // load last played track
try { try {
let lastItem = window.localStorage.getItem("currentTrack") let lastItem = window.localStorage.getItem("currentTrack")

View file

@ -35,11 +35,10 @@
<div class="md-option-segment md-option-segment_auto"> <div class="md-option-segment md-option-segment_auto">
<select class="md-select" style="width:180px;" v-model="app.cfg.audio.quality" <select class="md-select" style="width:180px;" v-model="app.cfg.audio.quality"
v-on:change="changeAudioQuality"> v-on:change="changeAudioQuality">
<!-- // <option value="9216">{{$root.getLz('settings.header.audio.quality.hireslossless')}}</option> --> <!-- // <option value="">{{$root.getLz('settings.header.audio.quality.hireslossless')}}</option> -->
<!-- <option value="2304">{{$root.getLz('settings.header.audio.quality.lossless')}}</option> --> <!-- <option value="">{{$root.getLz('settings.header.audio.quality.lossless')}}</option> -->
<option value="256">{{$root.getLz('settings.header.audio.quality.high')}}</option> <option value="HIGH">{{$root.getLz('settings.header.audio.quality.high')}} ({{$root.getLz('settings.header.audio.quality.high.description')}})</option>
<option value="64">{{$root.getLz('settings.header.audio.quality.low')}}</option> <option value="STANDARD">{{$root.getLz('settings.header.audio.quality.standard')}} ({{$root.getLz('settings.header.audio.quality.standard.description')}})</option>
<option value="auto">{{$root.getLz('settings.header.audio.quality.auto')}}</option>
</select> </select>
</div> </div>
</div> </div>
@ -823,8 +822,8 @@
} }
}, },
changeAudioQuality: function () { changeAudioQuality: function () {1
app.mk.bitrate = app.cfg.audio.quality app.mk.bitrate = MusicKit.PlaybackBitrate[app.cfg.audio.quality];
}, },
toggleUserInfo: function () { toggleUserInfo: function () {
app.chrome.hideUserInfo = !app.cfg.visual.showuserinfo app.chrome.hideUserInfo = !app.cfg.visual.showuserinfo