okseby/Quake-III-Arena
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

I'll retain the new way seeding the random number generator.. these calls are therefore redundant

Browse source
This commit is contained in:
Thilo Schulz 2009-05-31 20:30:37 +00:00
parent e4d0c14f70
commit 4e8a181073
4 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
code/client/cl_main.c
View file

@ -1306,11 +1306,7 @@ void CL_RequestMotd( void ) {
BigShort( cls.updateServer.port ) ); BigShort( cls.updateServer.port ) );
info[0] = 0; info[0] = 0;
// NOTE TTimo xoring against Com_Milliseconds, otherwise we may not have a true randomization
// only srand I could catch before here is tr_noise.c l:26 srand(1001)
// https://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=382
// NOTE: the Com_Milliseconds xoring only affects the lower 16-bit word,
// but I decided it was enough randomization
Com_sprintf( cls.updateChallenge, sizeof( cls.updateChallenge ), "%i", ((rand() << 16) ^ rand()) ^ Com_Milliseconds()); Com_sprintf( cls.updateChallenge, sizeof( cls.updateChallenge ), "%i", ((rand() << 16) ^ rand()) ^ Com_Milliseconds());
Info_SetValueForKey( info, "challenge", cls.updateChallenge ); Info_SetValueForKey( info, "challenge", cls.updateChallenge );

1
code/qcommon/common.c
View file

@ -3340,7 +3340,6 @@ void Com_RandomBytes( byte *string, int len )
return; return;
Com_Printf( "Com_RandomBytes: using weak randomization\n" ); Com_Printf( "Com_RandomBytes: using weak randomization\n" );
srand( time( 0 ) );
for( i = 0; i < len; i++ ) for( i = 0; i < len; i++ )
string[i] = (unsigned char)( rand() % 255 ); string[i] = (unsigned char)( rand() % 255 );
} }

2
code/renderer/tr_noise.c
View file

@ -44,8 +44,6 @@ void R_NoiseInit( void )
{ {
int i; int i;
srand( 1001 );
for ( i = 0; i < NOISE_SIZE; i++ ) for ( i = 0; i < NOISE_SIZE; i++ )
{ {
s_noise_table[i] = ( float ) ( ( ( rand() / ( float ) RAND_MAX ) * 2.0 - 1.0 ) ); s_noise_table[i] = ( float ) ( ( ( rand() / ( float ) RAND_MAX ) * 2.0 - 1.0 ) );

1
code/server/sv_init.c
View file

@ -475,7 +475,6 @@ void SV_SpawnServer( char *server, qboolean killBots ) {
Cvar_Set("cl_paused", "0"); Cvar_Set("cl_paused", "0");
// get a new checksum feed and restart the file system // get a new checksum feed and restart the file system
srand(Com_Milliseconds());
sv.checksumFeed = ( ((int) rand() << 16) ^ rand() ) ^ Com_Milliseconds(); sv.checksumFeed = ( ((int) rand() << 16) ^ rand() ) ^ Com_Milliseconds();
FS_Restart( sv.checksumFeed ); FS_Restart( sv.checksumFeed );