okseby/Quake-III-Arena
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* Fix to multiple buffer overflow bugs in CL_Rcon_f

Browse source 
* Fix to COM_ParseExt 1 byte overwrite bug
* Fixed some missing calls to trap_FS_FCloseFile
* Fixed q3msgboom and q3infoboom bugs
* Fixed some qboolean type confusion
* Above fixes from http://www.quakesrc.org/forums/viewtopic.php?t=5374
This commit is contained in:
Tim Angus 2005-09-19 17:45:29 +00:00
parent b185817285
commit 33a48a0336
9 changed files with 26 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
code/client/cl_keys.c
View file

@ -42,7 +42,7 @@ int chat_playerNum;
qboolean key_overstrikeMode;
qboolean anykeydown;
int anykeydown;
qkey_t keys[MAX_KEYS];
@ -1238,7 +1238,7 @@ void Key_ClearStates (void)
{
int i;
anykeydown = qfalse;
anykeydown = 0;
for ( i=0 ; i < MAX_KEYS ; i++ ) {
if ( keys[i].down ) {

11
code/client/cl_main.c
View file

@ -1090,6 +1090,7 @@ void CL_Connect_f( void ) {
Cvar_Set( "cl_currentServerAddress", server );
}
#define MAX_RCON_MESSAGE 1024
/*
=====================
@ -1100,7 +1101,7 @@ CL_Rcon_f
=====================
*/
void CL_Rcon_f( void ) {
char message[1024];
char message[MAX_RCON_MESSAGE];
netadr_t to;
if ( !rcon_client_password->string ) {
@ -1115,13 +1116,13 @@ void CL_Rcon_f( void ) {
message[3] = -1;
message[4] = 0;
strcat (message, "rcon ");
Q_strcat (message, MAX_RCON_MESSAGE, "rcon ");
strcat (message, rcon_client_password->string);
strcat (message, " ");
Q_strcat (message, MAX_RCON_MESSAGE, rcon_client_password->string);
Q_strcat (message, MAX_RCON_MESSAGE, " ");
// https://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=543
strcat (message, Cmd_Cmd()+5);
Q_strcat (message, MAX_RCON_MESSAGE, Cmd_Cmd()+5);
if ( cls.state >= CA_CONNECTED ) {
to = clc.netchan.remoteAddress;

2
code/client/keys.h
View file

@ -43,7 +43,7 @@ extern field_t historyEditLines[COMMAND_HISTORY];
extern field_t g_consoleField;
extern field_t chatField;
extern qboolean anykeydown;
extern int anykeydown;
extern qboolean chat_team;
extern int chat_playerNum;