okseby/Quake-III-Arena
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid 'register' declarations

Browse source 
gcc 6 with -Wall -Wextra warns:

code/botlib/l_precomp.c: In function ‘PC_NameHash’:
code/botlib/l_precomp.c:551:2: warning: ‘register’ is not at beginning of declaration [-Wold-style-declaration]
  int register hash, i;
  ^~~

Modern compilers either ignore the register storage class when
generating code, or generate better code without it, so just remove
most of them.

The remaining uses are in third-party bundled libraries (libjpeg, zlib),
and in a PowerPC-specific inline function consisting of inline
assembler (because I'm not 100% confident that it doesn't have
some practical use there).
This commit is contained in:
Simon McVittie 2016-09-29 23:37:15 +01:00
parent 863adfcfc2
commit 2ab109b772
6 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
code/renderergl1/tr_surface.c
View file

@ -563,8 +563,8 @@ static void VectorArrayNormalize(vec4_t *normals, unsigned int count)
#if idppc
{
register float half = 0.5;
register float one = 1.0;
float half = 0.5;
float one = 1.0;
float *components = (float *)normals;
// Vanilla PPC code, but since PPC has a reciprocal square root estimate instruction,